test(ts-plugin): flatten e2e-test directory#383
Merged
Conversation
…regression/ Move all test files from feature/ and regression/ subdirectories into e2e-test/ root. Adjust import paths accordingly. File names are preserved in this commit; renames will follow in a subsequent commit.
- disabled.test.ts -> enabled.test.ts: neutral framing that also fits future tests for `enabled: true` - file-operation.test.ts -> file-events.test.ts: replace vague "operation" with the actual subject (filesystem events at runtime) - invalid-syntax.test.ts -> invalid-css-syntax.test.ts: make explicit which language's syntax is meant - pure-css-file.test.ts -> non-module-css-file.test.ts: literal description of the file kind (not a `*.module.css`) instead of the ambiguous "pure CSS"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flatten the
packages/ts-plugin/e2e-test/directory by removing thefeature/andregression/subdirectories, placing all test files at the e2e-test root. Also rename a few non-feature test files for clarity.This completes the e2e test reorganization started in #378 and continued through #382.
What's new
feature/directory: 9 test files moved to e2e-test root.regression/directory: 1 test file (pure-css-file.test.ts) moved to e2e-test root and renamed tonon-module-css-file.test.ts.disabled.test.ts->enabled.test.tsfile-operation.test.ts->file-events.test.tsinvalid-syntax.test.ts->invalid-css-syntax.test.tspure-css-file.test.ts->non-module-css-file.test.tsThe directory structure is now flat: each test file's name is self-descriptive and there is no taxonomy to learn before adding a new test.
Rationale
Previously, the
feature/directory grouped tsserver-API-driven tests andregression/held a single issue-specific test, while several "cross-cutting" tests (config, parser, runtime events) lived at the root. There was no natural directory name for those cross-cutting tests, and a single-fileregression/directory provided no organizational value. A flat layout removes the naming problem entirely and makes file discovery trivial: if you want a test, look at the filename.Naming refinements
disabled->enabled: neutral framing that also fits future tests forenabled: true.file-operation->file-events: replace vague "operation" with the actual subject (filesystem events at runtime).invalid-syntax->invalid-css-syntax: make explicit which language's syntax is meant.pure-css-file->non-module-css-file: literal description of the file kind (not a*.module.css) instead of the ambiguous "pure CSS".Commits
feature/andregression/(move only; import paths adjusted).Test plan
vp test --project e2e-- 15 files / 135 tests passvp check-- format, lint, type all pass